cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From DrJojo <...@git.apache.org>
Subject [GitHub] cordova-plugin-geolocation pull request: Wrong parameter in Firefo...
Date Fri, 21 Nov 2014 07:28:51 GMT
GitHub user DrJojo opened a pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/31

    Wrong parameter in Firefox OS plugin addWatch() function

    Calling `geolocation.watchPosition()` in Firefox OS will return empty coords because `addWatch()`
omits same position object conversion like in `getLocation()`.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/DrJojo/cordova-plugin-geolocation master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-geolocation/pull/31.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #31
    
----
commit 3b06100d419f550208a71581bf3a9ae44f461a75
Author: Jojo Degenhardt <jost.degenhardt@gmail.com>
Date:   2014-11-21T07:24:23Z

    Wrong parameter in Firefox OS plugin
    
    Calling geolocation.watchPosition() in Firefox OS will return empty coords because addWatch()
omits same position object conversion like in getLocation().

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message