cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From pencilcheck <...@git.apache.org>
Subject [GitHub] cordova-plugin-media-capture pull request: Write the recorded file...
Date Tue, 04 Nov 2014 08:35:41 GMT
GitHub user pencilcheck opened a pull request:

    https://github.com/apache/cordova-plugin-media-capture/pull/28

    Write the recorded files to external storage directory so they can be read after onActivityResult
is called.

    The original temporary cache directory is not readable since you cannot do playback what
you just recorded in the camera app. Likewise causing the path not available after the the
activity result has been called.
    
    By changing the path to external storage directory it allows the file to be read.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/pencilcheck/cordova-plugin-media-capture master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media-capture/pull/28.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #28
    
----
commit 28f125ae64434a72c72c08f3bcf87a65d46c619b
Author: Penn Su <pennsu@gmail.com>
Date:   2014-11-04T05:46:26Z

    Send EXTRA_OUTPUT for captureVideo as well to fix a bug where the video
    file is not saved correctly

commit 2514e401c029ebb5a2cf9d203a65a292cecd3769
Author: Penn Su <pennsu@gmail.com>
Date:   2014-11-04T06:05:37Z

    Change tmpdirectory to externalsotragedirectory

commit 37a394540e006d93fe4216fe3284be9671df744f
Author: Penn Su <pennsu@gmail.com>
Date:   2014-11-04T06:10:00Z

    Add the missing semicolon

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message