cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From TimBarham <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-8053: Including a project reference i...
Date Fri, 21 Nov 2014 04:21:59 GMT
GitHub user TimBarham opened a pull request:

    https://github.com/apache/cordova-lib/pull/121

    CB-8053: Including a project reference in a plugin fails on Windows plat...

    When working with the Windows platform, the existing logic to add a project reference
was expecting two things:
    
    1. There would only be one solution file.
    2. That solution file would only contain a single project.
    
    This is no longer true - there are now two solution files (one for VS 2012 and one for
VS 2013). The VS 2013 solution is for a universal project, and contains five projects.
    
    The change here is to make the code (in cordova-lib/src/util/windows/jsproj.js) which
modifies the solution file more versatile by:
    
    1. Handling any number of solution files (iterate all solution files we find).
    2. Handling any number of projects in the solution (add the build depedency to every jsproj
in the solution).
    
    Includes matching changes to removeProjectReference(), and fixes a call in cordova-lib/src/plugman/platforms/windows.js
to pass the correct path for plugin_dir.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-8053-B

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/121.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #121
    
----
commit 623233d099d7874be134fe4a9e0b645a7426eb57
Author: Tim Barham <tim.barham@microsoft.com>
Date:   2014-11-21T03:51:39Z

    CB-8053: Including a project reference in a plugin fails on Windows platform.
    
    When working with the Windows platform, the existing logic to add a project reference
was expecting two things:
    
    1. There would only be one solution file.
    2. That solution file would only contain a single project.
    
    This is no longer true - there are now two solution files (one for VS 2012 and one for
VS 2013). The VS 2013 solution is for a universal project, and contains five projects.
    
    The change here is to make the code (in cordova-lib/src/util/windows/jsproj.js) which
modifies the solution file more versatile by:
    
    1. Handling any number of solution files (iterate all solution files we find).
    2. Handling any number of projects in the solution (add the build depedency to every jsproj
in the solution).
    
    Includes matching changes to removeProjectReference(), and fixes a call in cordova-lib/src/plugman/platforms/windows.js
to pass the correct path for plugin_dir.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message