cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Bowser <bows...@gmail.com>
Subject Re: Cordova: Comment on Deleting hidekeyboard and showkeyboard Events
Date Thu, 06 Nov 2014 00:30:36 GMT
We're spending a lot of time debating killing an undocumented feature that
works instead of fixing documented features that don't work.  I'm not sure
why you're so dead set on deleting this particular feature.


On Wed Nov 05 2014 at 3:54:32 PM Andrew Grieve <agrieve@chromium.org> wrote:

> Regardless of the technical debt, these events:
> 1. Don't exist on iOS nor Windows (didn't check other platforms)
> 2. Are not documented (at least not at
> http://cordova.apache.org/docs/en/4.0.0/cordova_events_
> events.md.html#Events
> )
> 3. Are implemented using logic that could be done in JS (using onresize
> events)
> 4. Can also be implemented using a plugin (Ionic is an example, but it's
> pretty easy to copy & paste the Stack Overflow code into one of your own)
>
> Let's just get rid of them in 4.0.x
>
> W
>
> On Wed, Nov 5, 2014 at 4:24 PM, Joe Bowser <bowserj@gmail.com> wrote:
>
> > On Wed Nov 05 2014 at 1:19:43 PM Jesse <purplecabbage@gmail.com> wrote:
> >
> > > Michal, are you trolling?
> > >
> > >
> > I don't think this is a troll.  This is more about trying to shed some
> > technical debt.  This code is old and can break if you change a
> preference
> > from adjustResize to adjustPan.  That said, Ionic wanting to buy our debt
> > isn't a super awesome situation, since they could cash it in later by
> > abandoning the plugin and cause us to have to deal with the technical
> debt
> > again.
> >
> >
> > > I do think this specific case is best handled in a plugin, but pushing
> > > people to use ionic's also means that anyone who is developing outside
> of
> > > iOS and Android is screwed.
> > >
> > >
> > So, do we want to adopt a core plugin, or add this code to the keyboard
> > plugin that iOS has? Who is going to feed this puppy and scoop up the
> > poops?
> >
> >
> > >
> > >
> > >
> > > @purplecabbage
> > > risingj.com
> > >
> > > On Wed, Nov 5, 2014 at 10:03 AM, Joe Bowser <bowserj@gmail.com> wrote:
> > >
> > > > On Wed Nov 05 2014 at 8:50:59 AM Michal Mocny <mmocny@chromium.org>
> > > wrote:
> > > >
> > > > > Telling people to turn to [insert any project from the external
> > > > community]
> > > > > for [a feature we used to support but is now openly supported
> > > elsewhere]
> > > > --
> > > > > sounds amazing to me.
> > > > >
> > > > > What happened to the goal of "eventually cease to exist"?
> > > > >
> > > >
> > > > Yeah, but it actually has to work.  We've been poly-filling broken
> > > browser
> > > > features for years!
> > > >
> > > >
> > > > >
> > > > > On Wed, Nov 5, 2014 at 11:26 AM, Joe Bowser <bowserj@gmail.com>
> > wrote:
> > > > >
> > > > > > On Wed Nov 05 2014 at 8:21:03 AM Andrew Grieve <
> > agrieve@chromium.org
> > > >
> > > > > > wrote:
> > > > > >
> > > > > > > Here's the ionic plugin:
> > > > > > >
> > > > > > https://github.com/driftyco/ionic-plugins-keyboard/blob/
> > > > > master/src/android/IonicKeyboard.java
> > > > > > >
> > > > > > > Uses a GlobalLayoutListener. the approach is described
here:
> > > > > > >
> > > > > > http://stackoverflow.com/questions/2150078/how-to-
> > > > > check-visibility-of-software-keyboard-in-android
> > > > > > >
> > > > > > > Why leave the code in core if we don't have to? I think
the
> > > majority
> > > > of
> > > > > > > apps wouldn't need these events (even if you do, you can
listen
> > for
> > > > > > resize
> > > > > > > events to do the same kind of detection)
> > > > > > >
> > > > > >
> > > > > > I think this will break more things than it'll fix.  Does the
> Ionic
> > > > > plugin
> > > > > > support all the versions of Android that we currently support?
> Are
> > we
> > > > > > really going to tell people to go to Ionic for a feature that
we
> > once
> > > > > > supported? Even if this is technically better, this seems like
> > it's a
> > > > > > support nightmare.
> > > > > >
> > > > > >
> > > > > > >
> > > > > > > On Wed, Nov 5, 2014 at 11:05 AM, Joe Bowser <bowserj@gmail.com
> >
> > > > wrote:
> > > > > > >
> > > > > > >> I disagree. We recently fixed this when we went back
to
> > > adjustResize
> > > > > > from
> > > > > > >> adjustPan, and we should just file a bug about the
behaviour
> on
> > > the
> > > > > > Samsung
> > > > > > >> Tablet.
> > > > > > >>
> > > > > > >
> > > > > > >
> > > > > >
> > > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message