cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Shazron <shaz...@gmail.com>
Subject Re: Fix for `cordova emulate ios` to support iPhone 6
Date Wed, 12 Nov 2014 15:27:33 GMT
Here is the file history:
https://github.com/apache/cordova-ios/commits/master/bin/templates/scripts/cordova/run

Thank you however for contributing! I would encourage you to file pull
requests in the future. The repo itself has a CONTRIBUTING.md with
guidelines. Each pull request should be accompanied by a JIRA issue as well.

On Wed, Nov 12, 2014 at 7:23 AM, Shazron <shazron@gmail.com> wrote:

> Hi Seth,
> The run script does not exist in the cordova-cli, it exists in the
> cordova-ios repo, and I believe this issue has already been fixed in 3.7.0.
>
> On Tue, Nov 11, 2014 at 5:24 PM, Seth Voltz <seth@designgods.net> wrote:
>
>> Hello,
>>
>> I just started with Cordova and wanted to keep everything on the CLI so I
>> can run the build and emulate cycle without having to open Xcode. In order
>> to support the iPhone 6 I edited the `platforms/ios/cordova/run` file to
>> use ios-sim 3.x’s —devicetypeid syntax.
>>
>> I have attached it here but I would like to contribute this back to the
>> community as well. Is the only channel for submitting fixes through Jira or
>> can I fork on GitHub and submit a pull request?
>>
>> Thanks!
>>
>> – Seth
>>
>>
>>
>>
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message