cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Mark Koudritsky <kam...@google.com>
Subject Re: [VOTE] Tools Release
Date Mon, 10 Nov 2014 22:16:47 GMT
This vote is cancelled.

Blocking issue https://issues.apache.org/jira/browse/CB-8000
Will post a new vote with updated packages

On Mon, Nov 10, 2014 at 12:34 PM, Sergey Grebnov (Akvelon) <
v-segreb@microsoft.com> wrote:

> Thank you Mark; Resending link to the fix here since looks like I answered
> not to the latest email last time.
> https://github.com/apache/cordova-lib/pull/118/
>
> Thx!
> Sergey
> -----Original Message-----
> From: Mark Koudritsky [mailto:kamrik@google.com]
> Sent: Monday, November 10, 2014 9:14 AM
> To: dev@cordova.apache.org
> Subject: Re: [VOTE] Tools Release
>
> Yep, the hash as a versions seems like something that should break the npm
> download as well.
> Sergey, I'll merge your patch and republish rc packages.
> Maria, thanks for finding this.
>
> Note, the lib will have a different version number 4.1.1 because npm
> forbids uploading anything with the same version string more than once [1].
> We should come up with some procedure of promoting RCs that would not
> necessitate bumping the version.
>
> One option is to download the package with x.y.z-rcN from npm, and have a
> script that unpacks it, strips the -rcN and repacks the same files back.
> (not sure how to deal with signing in this case).
>
> [1] - https://github.com/npm/npm-registry-couchapp/issues/148
>
> On Mon, Nov 10, 2014 at 12:06 PM, Sergey Grebnov (Akvelon) <
> v-segreb@microsoft.com> wrote:
>
> > I've found the case will submit the patch shortly - Jira +PR to master
> >
> > Problem cause: we've recently got rid of subdirs for wp8 and windows
> > but still have them defined in tools.
> >
> > https://github.com/apache/cordova-lib/blob/master/cordova-lib/src/cord
> > ova/platformsConfig.json#L53
> >
> > Thx!
> > Sergey
> > -----Original Message-----
> > From: Steven Gill [mailto:stevengill97@gmail.com]
> > Sent: Monday, November 10, 2014 8:57 AM
> > To: dev@cordova.apache.org
> > Subject: RE: [VOTE] Tools Release
> >
> > Definitely a problem. Thanks for testing and finding it!
> >
> > -1
> > On Nov 10, 2014 8:51 AM, "Maria Bukharina"
> > <maria.bukharina@akvelon.com>
> > wrote:
> >
> > > Hi all,
> > >
> > > I've tried to create app with this rc and discover that adding wp8
> > > and windows platforms with --usegit key fails:
> > >
> > >         cordova platform add wp8 --usegit
> > >         Creating wp8 project...
> > >         Error:.cordova\lib\wp\cordova\4.1.0\bin\create: Command
> > > failed with exit code ENOENT
> > >          at ChildProcess.whenDone
> > >
> > (d:\Projects\cordova\cordova4.1\cordova-lib-4.1.0\package\src\cordova\
> > superspawn.js:135:23)
> > >          at ChildProcess.EventEmitter.emit (events.js:95:17)
> > >          at Process.ChildProcess._handle.onexit
> > > (child_process.js:805:12)
> > >
> > >
> > > Seemed that file platformConfig.json in
> > > .\cordova-lib\cordova-lib\src\cordova has invalid data for wp8 and
> > > windows
> > > platforms:
> > > for wp8 there are wrong version and subdirectory properties:
> > > "wp8": {
> > >         "hostos": ["win32"],
> > >         "parser": "./metadata/wp8_parser",
> > >         "url":
> > > "https://git-wip-us.apache.org/repos/asf?p=cordova-wp8.git
> > > ",
> > >         "version": "b2b1e6185444e0dd6a6b9b19df9005cfc5bc5d80",
> > >         "altplatform": "wp",
> > >         "subdirectory": "3.7.0"
> > >     },
> > >
> > > windows for now doesn't contain subfolder "windows":
> > >     "windows": {
> > >         "hostos": ["win32"],
> > >         "parser": "./metadata/windows_parser",
> > >         "url": "
> > > https://git-wip-us.apache.org/repos/asf?p=cordova-windows.git",
> > >         "version": "3.7.0",
> > >         "subdirectory": "windows"
> > >     },
> > >
> > > What's your opinion, is it critical for release?
> > >
> > >
> > > Thanks,
> > > Maria
> > >
> > > -----Original Message-----
> > > From: Mark Koudritsky [mailto:kamrik@google.com]
> > > Sent: Saturday, November 8, 2014 01:17
> > > To: dev@cordova.apache.org
> > > Subject: [VOTE] Tools Release
> > >
> > > Please review and vote on this Tools Release.
> > >
> > > Release issue: https://issues.apache.org/jira/browse/CB-7988
> > >
> > > Packages have been published to dist/dev:
> > > https://dist.apache.org/repos/dist/dev/cordova/CB-7988/
> > > And to npm under @rc tag
> > >
> > > To test them out you can use:
> > >     npm -g uninstall cordova
> > >     npm -g install cordova@rc
> > >
> > > The packages were published from their corresponding git tags:
> > >
> > >     cordova-js: 3.7.2 (7afadfc044)
> > >     cordova-lib: 4.1.0 (0141806d73)
> > >     cordova-plugman: 0.22.14 (cdb84dda53)
> > >     cordova-cli: 4.1.0 (e33cfc90a0)
> > >
> > > Upon a successful vote I will upload the archives to dist/, publish
> > > them to NPM (under @latest tag), and post the corresponding blog post.
> > >
> > > Voting guidelines:
> > > https://github.com/apache/cordova-coho/blob/master/docs/release-voti
> > > ng
> > > .md
> > >
> > > Voting will go on for a minimum of 48 hours.
> > >
> > > I vote +1:
> > > * Ran coho audit-license-headers over the relevant repos
> > > * tested with npm test and mobilespec on Android
> > >
> >
> > ---------------------------------------------------------------------
> > To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
> > For additional commands, e-mail: dev-help@cordova.apache.org
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message