cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <>
Subject [GitHub] cordova-plugin-dialogs pull request: Fix CB-7734. Changed plugin t...
Date Fri, 14 Nov 2014 20:23:53 GMT
Github user shazron commented on the pull request:
    Hi Julio,
    I'm sure you will have followed the dev@ discussion by now.
    Two changes are required, since you are using iOS 8 API code.
    1. Change your use of `[UIAlertController class]` to `NSClassFromString(@"UIAlertController")`.
On iOS devices < iOS 8 your code will crash.
    2. Wrap the whole code block with iOS 8 code with `#ifdef __IPHONE_8_0`. This way people
using the Xcode 5 (which is still allowed by Apple) will not have compilation errors.
    I would test the adjusted code out on an iOS 7 and iOS 8 device, and compile using Xcode
5 and 6.

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message