Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: clelland <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-116-cordova-ios@git.apache.org>
In-Reply-To: <git-pr-116-cordova-ios@git.apache.org>
Subject: [GitHub] cordova-ios pull request: Unplug whitelist - review
Content-Type: text/plain
Message-Id: <20141029150829.BC952A00B74@tyr.zones.apache.org>
Date: Wed, 29 Oct 2014 15:08:29 +0000 (UTC)

Github user clelland commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/116#discussion_r19543890
  
    --- Diff: CordovaLib/Classes/CDVViewController.m ---
    @@ -714,24 +712,44 @@ - (BOOL)webView:(UIWebView*)theWebView shouldStartLoadWithRequest:(NSURLRequest*
         }
     
         /*
    -     * If a URL is being loaded that's a file/http/https URL, just load it internally
    +     *    If we loaded the HTML from a string, we let the app handle it
          */
    -    if ([url isFileURL]) {
    +    if (self.loadFromString == YES) {
    --- End diff --
    
    Yes. Yes it can :) Thanks


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org