Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: agrieve <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-132-cordova-android@git.apache.org>
In-Reply-To: <git-pr-132-cordova-android@git.apache.org>
Subject: [GitHub] cordova-android pull request: Unplug whitelist
Content-Type: text/plain
Message-Id: <20141029141904.C55D0A00996@tyr.zones.apache.org>
Date: Wed, 29 Oct 2014 14:19:03 +0000 (UTC)

Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/132#discussion_r19540066
  
    --- Diff: framework/src/org/apache/cordova/AndroidWebView.java ---
    @@ -354,7 +349,9 @@ private void loadUrlNow(String url) {
             if (LOG.isLoggable(LOG.DEBUG) && !url.startsWith("javascript:")) {
                 LOG.d(TAG, ">>> loadUrlNow()");
             }
    -        if (url.startsWith("file://") || url.startsWith("javascript:") || internalWhitelist.isUrlWhiteListed(url)) {
    +        Boolean shouldAllowNavigation = pluginManager.shouldAllowNavigation(url);
    +        if (url.startsWith("file://") || url.startsWith("javascript:") ||
    --- End diff --
    
    Since shouldAllowNavigtion is tri-state, I think we should do the default behaviour only when non-null


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org