Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id ADBC510CA5 for ; Fri, 24 Oct 2014 08:44:01 +0000 (UTC) Received: (qmail 9344 invoked by uid 500); 24 Oct 2014 08:44:01 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 9297 invoked by uid 500); 24 Oct 2014 08:44:01 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 9286 invoked by uid 99); 24 Oct 2014 08:44:00 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 24 Oct 2014 08:44:00 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 886DF51DB9; Fri, 24 Oct 2014 08:44:00 +0000 (UTC) From: sgrebnov To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org References: In-Reply-To: Subject: [GitHub] cordova-android pull request: Ignore --device option in Android bu... Content-Type: text/plain Message-Id: <20141024084400.886DF51DB9@tyr.zones.apache.org> Date: Fri, 24 Oct 2014 08:44:00 +0000 (UTC) Github user sgrebnov commented on the pull request: https://github.com/apache/cordova-android/pull/127#issuecomment-60360056 LGTM I would probably warn if there is some unrecognized option instead of failing. This will simplify moving forward. --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. --- --------------------------------------------------------------------- To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org For additional commands, e-mail: dev-help@cordova.apache.org