Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
From: khawkins <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-84-cordova-js@git.apache.org>
In-Reply-To: <git-pr-84-cordova-js@git.apache.org>
Subject: [GitHub] cordova-js pull request: Some user agent-related changes in
 suppor...
Content-Type: text/plain
Message-Id: <20141007211037.EFF509055E6@tyr.zones.apache.org>
Date: Tue,  7 Oct 2014 21:10:37 +0000 (UTC)

Github user khawkins commented on a diff in the pull request:

    https://github.com/apache/cordova-js/pull/84#discussion_r18549351
  
    --- Diff: src/ios/exec.js ---
    @@ -230,7 +223,7 @@ function pokeNativeViaXhr() {
         // Add a timestamp to the query param to prevent caching.
         execXhr.open('HEAD', "/!gap_exec?" + (+new Date()), true);
         if (!vcHeaderValue) {
    -        vcHeaderValue = /.*\((.*)\)/.exec(navigator.userAgent)[1];
    +        vcHeaderValue = /.*\((.*)\)$/.exec(navigator.userAgent)[1];
    --- End diff --
    
    In the wake of configurable user agents, this is more deterministic.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org