Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
From: SomaticIT <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-54-cordova-plugin-file@git.apache.org>
In-Reply-To: <git-pr-54-cordova-plugin-file@git.apache.org>
Subject: [GitHub] cordova-plugin-file pull request: CB-6994 - Windows 8 does
 not sav...
Content-Type: text/plain
Message-Id: <20141007161805.722978B5FA8@tyr.zones.apache.org>
Date: Tue,  7 Oct 2014 16:18:04 +0000 (UTC)

Github user SomaticIT commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/54#discussion_r18530459
  
    --- Diff: src/windows/FileProxy.js ---
    @@ -518,36 +518,69 @@ module.exports = {
             if (data instanceof ArrayBuffer) {
    --- End diff --
    
    I did not remove this line in my update since user can pass ArrayBuffer directly to FileWriter.write.
    In this case, we need to convert ArrayBuffer. I optimized the conversion by using DataView to transform ArrayBuffer into Blob and use the best method to write big files.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org