cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From purplecabbage <...@git.apache.org>
Subject [GitHub] cordova-js pull request: Cb 964 Error in success callback should g...
Date Wed, 01 Oct 2014 23:23:18 GMT
GitHub user purplecabbage opened a pull request:

    https://github.com/apache/cordova-js/pull/82

    Cb 964 Error in success callback should generate event

    Error in success callback should generate event
    
    - exception handling code moved to common function
    - a callback success with a status != cordova.callbackStatus.OK is treated as an error,
and passed to the error handler, it was previously just swallowed
    - exceptions are output to console.log if it exists
    - exceptions are caught, and the window will fire an event `cordovacallbackerror` with
a message property that contains the callbackID, and other info from the exception.
    - the exception is re-thrown, so native code can also potentially respond.


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/purplecabbage/cordova-js CB-964

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-js/pull/82.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #82
    
----
commit 9eb4f7faf607ae22fb8b6ee31d24fd622dbaf64c
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2014-10-01T23:00:41Z

    callbackSuccess|Error both call callbackFromNative, which catches and rethrows the exception
per CB-964

commit 880ffea995065ca79335c66afdde863c6c2abf39
Author: Jesse MacFadyen <purplecabbage@gmail.com>
Date:   2014-10-01T23:17:42Z

    browserify version rethrows also

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message