cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From ionut-movila <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request: Fixed the problem with multiple...
Date Mon, 06 Oct 2014 12:55:16 GMT
GitHub user ionut-movila opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/33

    Fixed the problem with multiple sounds not playing at the same time

    The problem is visible on iOS 8 if someone wants to play multiple sounds at the same time.
When one sound ends (is released) AVSession (that is a shared instance per app) is set not
active, causing other playing sounds to stop playing.
    
    My simple solution was to remove all calls where the shared app. AVSession is inactivated.
Should not cause memory leaks since it's a shared instance.
    
    Could be that this AVSession should be released when app is paused.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/ionut-movila/cordova-plugin-media master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/33.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #33
    
----
commit 2bfdba0a8776b55e26eaafd362c130f9a7a81cd2
Author: Ionut Movila <ionut@epekebok.no>
Date:   2014-10-06T12:48:43Z

    Fixed the problem with multiple sounds not playing at the same time

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message