cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <>
Subject [GitHub] cordova-android pull request: Unplug whitelist
Date Wed, 29 Oct 2014 14:18:10 GMT
GitHub user agrieve opened a pull request:

    Unplug whitelist

    Creating for code review.

You can merge this pull request into a Git repository by running:

    $ git pull unplug-whitelist

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #132
commit b56c12ff4ce8c904738f754138dc65f519bdf3bc
Author: Ian Clelland <>
Date:   2014-10-22T19:52:09Z

    Add hooks in CordovaPlugin and PluginManager for whitelist plugins
    This adds three hooks to CordovaPlugin objects. In each case, a null
    value can be returned to indicate "I don't care". This null value is
    the default.
        public Boolean shouldAllowRequest(String url)
        public Boolean shouldAllowNavigation(String url)
        public Boolean shouldOpenExternalUrl(String url)

commit 972540f4434b0b72f7d062e12652e9b1ac31c09b
Author: Ian Clelland <>
Date:   2014-10-22T20:16:52Z

    Defer whitelist decisions to plugins
    There is a default policy, which is implemented in the case where no plugins override
any of the whitelist methods:
     * Error URLs must start with file://
     * Navigation is allowed to file:// and data: URLs which do not contain "app_webview"
     * External URLs do not launch intents
     * XHRs are allowed to file:// and data: URLs which do not contain "app_webview"

commit 19563c6c813ccacb1c60793b5a0c944e7c713556
Author: Ian Clelland <>
Date:   2014-10-22T20:26:41Z

    Refactor ConfigXmlParser to allow subclasses

commit 9293484dd33a2d44f3aa37822481c25eb9a2595e
Author: Ian Clelland <>
Date:   2014-10-09T18:44:09Z

    Remove unused Config methods (Breaking Change)

commit a8e67d4ab43bf72ec5092be2d395edfb5065f0c5
Author: Ian Clelland <>
Date:   2014-10-09T19:28:29Z

    Remove whitelists from WebView classes

commit 7ff71731549709740282e28d5a1027ad77cbee01
Author: Ian Clelland <>
Date:   2014-10-22T20:27:28Z

    Remove whitelist config.xml parsing

commit c439565d1bd705e65e8fdcc36383b54835e4d42e
Author: Ian Clelland <>
Date:   2014-10-28T15:00:49Z

    Fix reversed condition for isUrlHarmful


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message