cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From dpogue <...@git.apache.org>
Subject [GitHub] cordova-android pull request: Ignore --device option in Android bu...
Date Sat, 11 Oct 2014 05:06:17 GMT
GitHub user dpogue opened a pull request:

    https://github.com/apache/cordova-android/pull/127

    Ignore --device option in Android build

    iOS uses the `--device` flag to indicate that it should build for the device rather than
the simulator. Until recently, Android simply ignored this option. Now it throws an error.
    
    This causes problems for people targeting multiple platforms with the CLI tools, because
a command like `cordova build --release --device` will now fail on Android, rather than building
both Android and iOS versions of the app.
    
    **Simple test case:**
    
    ```bash
    $ cordova init myapp
    $ cd ./myapp
    $ cordova platform add ios android
    $ cordova build --release --device --verbose
    ```

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/dpogue/cordova-android patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/127.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #127
    
----
commit 138b24b6865a37ebbc08336c23117629f961cd83
Author: Darryl Pogue <dvpdiner2@gmail.com>
Date:   2014-10-11T05:04:17Z

    Ignore --device option in android build
    
    iOS uses the `--device` flag to indicate that it should build for the
    device rather than the simulator. Until recently, Android simply ignored
    this option. Now it throws an error.
    
    This causes problems for people targeting multiple platforms with the CLI
    tools, because a command like `cordova build --release --device` will now
    fail on Android, rather than building both Android and iOS versions of the
    app.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message