cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agamemnus <...@git.apache.org>
Subject [GitHub] cordova-android pull request: Fix potential null pointer error iss...
Date Thu, 09 Oct 2014 06:34:58 GMT
GitHub user agamemnus opened a pull request:

    https://github.com/apache/cordova-android/pull/126

    Fix potential null pointer error issue.

    I am writing a Google Play APK expansion library.
    
    All the libraries I have seen so far store version data inside the content provider's
tag as meta-data, and again inside a separate .xml file. This is wrong, but they are forced
to do this because it is very difficult to figure out the code to source all data from one
xml file. I have done this, but it does require telling Cordova not to extract the zip file
before the plugin file is ready.
    
    To do that, I return a null value from APEZProvider (extends ContentProvider for APKs)
if the APK expansion plugin class instance didn't run yet. That of course causes Cordova to
crash because it doesn't have the null test I am proposing.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/agamemnus/cordova-android patch-1

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-android/pull/126.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #126
    
----
commit efb59884123cbf377de7746bf269ab741f86bbbe
Author: agamemnus <agamemnus@gmail.com>
Date:   2014-10-09T06:34:49Z

    Fix potential null pointer error issue.
    
    I am writing a Google Play APK expansion library.
    
    All the libraries I have seen so far store version data inside the content provider's
tag as meta-data, and again inside a separate .xml file. This is wrong, but they are forced
to do this because it is very difficult to figure out the code to source all data from one
xml file. I have done this, but it does require telling Cordova not to extract the zip file
before the plugin file is ready.
    
    To do that, I return a null value from APEZProvider (extends ContentProvider for APKs)
if the APK expansion plugin class instance didn't run yet. That of course causes Cordova to
crash because it doesn't have the null test I am proposing.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message