cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <>
Subject [GitHub] cordova-ios pull request: Unplug whitelist - review
Date Wed, 29 Oct 2014 14:32:56 GMT
GitHub user agrieve opened a pull request:

    Unplug whitelist - review


You can merge this pull request into a Git repository by running:

    $ git pull unplug-whitelist

Alternatively you can review and apply these changes as the patch at:

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #116
commit 0c013f6915580b69d35332c16fbd7079675a1e93
Author: Ian Clelland <>
Date:   2014-10-23T20:02:59Z

    Seperate config.xml parsing logic
    Separates the logic of finding config.xml and feeding its contents to a parser from the
task of choosing that parser and using its results

commit 83ba4cd06d6ba6b6db125b6dabe00176fda8d9b3
Author: Ian Clelland <>
Date:   2014-10-24T20:09:07Z

    Add hooks for whitelist plugins
    This allows plugins to implement two methods:
    - (BOOL)shouldAllowRequestForURL:(NSURL *)url
    - (BOOL)shouldAllowNavigationToURL:(NSURL *)url
    - (BOOL)shouldOpenExternalURL:(NSURL *)url

commit 5b41cd6fa45567551905ad43547535e52158132a
Author: Ian Clelland <>
Date:   2014-10-24T20:13:47Z

    Remove whitelist objects from CDVURLProtocol and CDVViewController classes

commit cc7c53deb4beb5cff57c6385f5d50f8bf748283f
Author: Ian Clelland <>
Date:   2014-10-24T20:14:15Z

    Remove whitelist config.xml parsing

commit 13d90874087116f07bbeacdbb4629228d9cf8153
Author: Ian Clelland <>
Date:   2014-10-27T14:59:40Z

    Defer whitelist decisions to plugins


If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message