cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From gorkem <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-6472 Merge dictionaries when updating...
Date Mon, 27 Oct 2014 19:48:00 GMT
GitHub user gorkem opened a pull request:

    https://github.com/apache/cordova-lib/pull/115

    CB-6472 Merge dictionaries when updating plist files

    Merges the dictionaries on plist files if both plist and the value from plugin.xml are
dictionaries. This makes it consistent with how it behaves with array values.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/gorkem/cordova-lib CB-6472

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/115.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #115
    
----
commit 6bb5592d76ea3fc426ff87c0f7091dd9d985df1c
Author: Gorkem Ercan <gorkem.ercan@gmail.com>
Date:   2014-10-27T17:35:09Z

    [CB-6472] Adding content to -Info.plist - Unexpected behaviour
    
    Merge instead of replace when the destination and source nodes
    are both of type dictionary. Adds underscore.js as a dependency

commit 87173e00ee3242bf070343fe22b1644c10b1a994
Author: Gorkem Ercan <gorkem.ercan@gmail.com>
Date:   2014-10-27T19:42:06Z

    Tests for merging dictionaries
    
    Tests plist, if dictionary keys are actually merged when it already exists.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message