cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Bowser <bows...@gmail.com>
Subject Re: android app crashes, performing async tasks before loadUrl
Date Wed, 01 Oct 2014 15:01:20 GMT
On Wed, Oct 1, 2014 at 7:20 AM, Andrew Grieve <agrieve@chromium.org> wrote:

> The ask had come up by someone, but I can't find the email now.
>
> My thinking at the time was that if you've customized the native code, then
> that's a bit going outside of our "we promise to not change a thing" zone.
> And if you were savvy enough to modify your Activity.java, then you'd be
> able to keep up with these kinds of changes.
>
>
I disagree.  There's many users who just embed Cordova who may have been
bitten by this.


> Is it that all worklight clients are broken by this? Or are there just some
> that have customized?
>
>
This broke a few of the tests as well.  I think that could be the first
sign that it would have broken these users.


> That said, I think your suggested fix is a great idea. It'll ease the
> upgrade and add the option for customizing prefs. Let's update the default
> template to call the override though.
>
>
> On Tue, Sep 30, 2014 at 3:48 PM, Marcel Kinard <cmarcelk@gmail.com> wrote:
>
> > Well, that illustration had a few typos. :-/ This one should be cleaner:
> >
> >
> https://github.com/cmarcelk/cordova-android/blob/init/framework/src/org/apache/cordova/CordovaActivity.java#L201
> >
> > On Sep 30, 2014, at 3:20 PM, Marcel Kinard <cmarcelk@gmail.com> wrote:
> >
> > > If there is a real need to be able to defer the preference activation
> > outside of onCreate() before 4.x, how about using a different signature,
> > like the following?
> > >
> >
> https://github.com/cmarcelk/cordova-android/blob/5862352ba64ec44fbf04a3dc87f108d951f3933f/framework/src/org/apache/cordova/CordovaActivity.java#L215
> >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message