cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-coho pull request: Cb-7904: Pull request for nightlys
Date Fri, 31 Oct 2014 20:14:39 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-coho/pull/58#discussion_r19690856
  
    --- Diff: src/npm-publish.js ---
    @@ -0,0 +1,77 @@
    +/*
    +Licensed to the Apache Software Foundation (ASF) under one
    +or more contributor license agreements.  See the NOTICE file
    +distributed with this work for additional information
    +regarding copyright ownership.  The ASF licenses this file
    +to you under the Apache License, Version 2.0 (the
    +"License"); you may not use this file except in compliance
    +with the License.  You may obtain a copy of the License at
    +
    +http://www.apache.org/licenses/LICENSE-2.0
    +
    +Unless required by applicable law or agreed to in writing,
    +software distributed under the License is distributed on an
    +"AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
    +KIND, either express or implied.  See the License for the
    +specific language governing permissions and limitations
    +under the License.
    +*/
    +
    +var optimist = require('optimist');
    +var apputil = require('./apputil');
    +var flagutil = require('./flagutil');
    +var repoutil = require('./repoutil');   
    +var executil = require('./executil');
    +var print = apputil.print;
    +
    +exports.publishTag = function*(argv) {
    +    var opt = flagutil.registerHelpFlag(optimist);
    +   
    +    //argv was passed through another function, set defaults to appease demand.
    +    if(argv) {
    +        opt = opt
    +            .options('tag', {
    +                default:argv.tag
    --- End diff --
    
    Since publishTag is called from main.js, you shouldn't do anything funny with the argv.
    
    instead though, maybe make a helper function that both publishTag and nightly call into
that have the args already parsed out?
    
    e.g. 
    publishTagCommand(argv)
    publishTag(tag, repos, pretend)


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message