cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From MariaBukharina <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: CB-7896 Pending tests for Sa...
Date Fri, 31 Oct 2014 18:41:16 GMT
Github user MariaBukharina commented on the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/49#issuecomment-61308935
  
    For now I've made changes only for “Windows” platform. The line you’ve mentioned
corresponds to other platform: “Windows Phone 8”. I'm not changing anything unrelated
to “Windows” platform otherwise I would have to test this PR on other platforms as well,
which is out of scope for this PR.
    
    Later on hopefully I will review tests for “Windows Phone 8” platform. If at that
time this PR won't be merged, I'll just add new commit to this PR (to avoid merging conflicts).
Otherwise I'll create another PR for “Windows Phone 8” platform.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message