cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stevengill <...@git.apache.org>
Subject [GitHub] cordova-coho pull request: Cb-7904: Pull request for nightlys
Date Thu, 30 Oct 2014 22:52:25 GMT
Github user stevengill commented on a diff in the pull request:

    https://github.com/apache/cordova-coho/pull/58#discussion_r19642142
  
    --- Diff: src/repoutil.js ---
    @@ -449,14 +450,23 @@ exports.forEachRepo = function*(repos, func) {
             var newPath = isInForEachRepoFunction ? path.join('..', repo.repoName) : repo.repoName;
     
             isInForEachRepoFunction = true;
    +        
    +        if(repo.id === 'lib'){
    +            newPath = newPath + '/cordova-lib'
    +        } 
             shelljs.cd(newPath);
    +
             if (shelljs.error()) {
                 apputil.fatal('Repo directory does not exist: ' + repo.repoName + '. First
run coho repo-clone.');
             }
             yield func(repo);
    +        
    +        if(repo.id === 'lib'){
    +            origPath = origPath + '/..';
    --- End diff --
    
    I'm confused about how I should check against isInForEachRepoFunction. It is set to true
and the top and false at the bottom. What should the check do?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message