cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-coho pull request: Cb-7904: Pull request for nightlys
Date Thu, 30 Oct 2014 14:10:06 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-coho/pull/58#discussion_r19606358
  
    --- Diff: src/repoutil.js ---
    @@ -449,14 +450,23 @@ exports.forEachRepo = function*(repos, func) {
             var newPath = isInForEachRepoFunction ? path.join('..', repo.repoName) : repo.repoName;
     
             isInForEachRepoFunction = true;
    +        
    +        if(repo.id === 'lib'){
    +            newPath = newPath + '/cordova-lib'
    +        } 
             shelljs.cd(newPath);
    +
             if (shelljs.error()) {
                 apputil.fatal('Repo directory does not exist: ' + repo.repoName + '. First
run coho repo-clone.');
             }
             yield func(repo);
    +        
    +        if(repo.id === 'lib'){
    +            origPath = origPath + '/..';
    --- End diff --
    
    Would make more sense to put this where you modify newPath. You should also be checking
against isInForEachRepoFunction


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message