cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: CB-7896 Pending tests for Sa...
Date Thu, 30 Oct 2014 04:36:44 GMT
Github user sgrebnov commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/49#discussion_r19587554
  
    --- Diff: tests/tests.js ---
    @@ -99,7 +110,14 @@ exports.defineAutoTests = function () {
                   afterEach(removeContact);
     
                   it("contacts.spec.6 should be able to find a contact by name", function
(done) {
    -                  if (isWindowsPhone) {
    +                  // Find method is not supported on Windows Store apps.
    +                  // also this test will be skipped for Windows Phone 8.1 because function
"save" not supported on WP8.1
    +                  if (isWindows) {
    +                      pending();
    +                      return;
    +                  }
    +
    +                  if (isWindowsPhone8) {
    --- End diff --
    
    Why done() w/o running any tests?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message