cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From clelland <>
Subject [GitHub] cordova-android pull request: Unplug whitelist
Date Wed, 29 Oct 2014 14:27:44 GMT
Github user clelland commented on a diff in the pull request:
    --- Diff: framework/src/org/apache/cordova/ ---
    @@ -429,7 +426,7 @@ public void showWebPage(String url, boolean openExternal, boolean
             if (!openExternal) {
                 // Make sure url is in whitelist
    -            if (url.startsWith("file://") || internalWhitelist.isUrlWhiteListed(url))
    +            if (url.startsWith("file://") || pluginManager.shouldAllowNavigation(url))
    --- End diff --
    Shoudl definitely check for null there -- to avoid NPE at the very least

If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at or file a JIRA ticket
with INFRA.

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message