cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agrieve <...@git.apache.org>
Subject [GitHub] cordova-android pull request: Unplug whitelist
Date Wed, 29 Oct 2014 14:20:19 GMT
Github user agrieve commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/132#discussion_r19540154
  
    --- Diff: framework/src/org/apache/cordova/AndroidWebView.java ---
    @@ -429,7 +426,7 @@ public void showWebPage(String url, boolean openExternal, boolean
clearHistory,
             if (!openExternal) {
     
                 // Make sure url is in whitelist
    -            if (url.startsWith("file://") || internalWhitelist.isUrlWhiteListed(url))
{
    +            if (url.startsWith("file://") || pluginManager.shouldAllowNavigation(url))
{
    --- End diff --
    
    ditto - also - should we check for null here? also also - make sense to make a helper
for combining default logic with pluginManager result?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message