cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shortstuffsushi <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: generates a workspace instead of subproj...
Date Mon, 20 Oct 2014 15:48:45 GMT
Github user shortstuffsushi commented on a diff in the pull request:

    https://github.com/apache/cordova-ios/pull/104#discussion_r19093263
  
    --- Diff: bin/create ---
    @@ -110,6 +110,9 @@ else
         cp -r "$PROJECT_TEMPLATE_DIR/__NON-CLI__.xcodeproj" "$PROJECT_PATH/$PROJECT_NAME.xcodeproj"
     fi
     cp -r "$PROJECT_TEMPLATE_DIR/__PROJECT_NAME__" "$PROJECT_PATH/$PROJECT_NAME"
    +cp -r "$PROJECT_TEMPLATE_DIR/__PROJECT_NAME__.xcworkspace" "$PROJECT_PATH/$PROJECT_NAME.xcworkspace"
    --- End diff --
    
    My mistake, apparently it was building with the standard cordova-ios lib, and not my local
copy (with your changes). It does seem to generate the workspace now, but there are a couple
of warnings that I believe could be cleaned up. I'm trying to isolate those changes now, and
will reply shortly.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message