cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: CB-6994 - Windows 8 does not sav...
Date Tue, 07 Oct 2014 18:20:26 GMT
Github user sgrebnov commented on a diff in the pull request:

    https://github.com/apache/cordova-plugin-file/pull/54#discussion_r18538458
  
    --- Diff: src/windows/FileProxy.js ---
    @@ -516,38 +556,50 @@ module.exports = {
                 isBinary = args[3];
     
             if (data instanceof ArrayBuffer) {
    -            data = Array.apply(null, new Uint8Array(data));
    +            var dataView = new DataView(data);
    +            data = new Blob([dataView]);
    --- End diff --
    
    In my case it fails with InvalidStateError. But the following code works. Pls double check
    if (data instanceof ArrayBuffer) {
        //var dataView = new DataView(data);
        //var data2 = new Blob([dataView]);
        data = new Blob([data]);
    }
    
    I see similar code is used in the following test
    http://jsperf.com/array-buffer-blob


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message