cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-plugin-file pull request: CB-6994 - Windows 8 does not sav...
Date Tue, 07 Oct 2014 14:25:31 GMT
Github user sgrebnov commented on the pull request:

    https://github.com/apache/cordova-plugin-file/pull/54#issuecomment-58192316
  
    Just an additional proposed improvement to improve readability (not critical): it will
be great if blob/array buffer writing logic is wrapped to separate functions (writeArrayBufferAsync/writeBlobAsync),
similar to
    Windows.Storage.FileIO.writeBytesAsync
    Windows.Storage.FileIO.writeTextAsync
    
    So we can continue using logic with writePromise:
    
    if (data instanceof ArrayBuffer) {
        writePromise = writeArrayBufferAsync;
    } else if (data instanceof Blob) {
        writePromise = writeBlobAsync;
    } else if ...



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message