cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From stacic <...@git.apache.org>
Subject [GitHub] cordova-mobile-spec pull request: Add new-style tests when using -...
Date Mon, 06 Oct 2014 00:40:02 GMT
Github user stacic commented on a diff in the pull request:

    https://github.com/apache/cordova-mobile-spec/pull/110#discussion_r18438884
  
    --- Diff: createmobilespec/createmobilespec.js ---
    @@ -413,6 +413,20 @@ function installPlugins() {
                              " install --platform " + platform +
                              " --project . --plugin " + path.join("..", "cordova-mobile-spec",
"dependencies-plugin") +
                              " --searchpath " + top_dir);
    +
    +			// Install new-style test plugins
    +			console.log("Adding plugin tests using plugman...");
    +			shelljs.ls('plugins').forEach(function(plugin) {
    --- End diff --
    
    There is a top-level Plugins directory (eg mobilespec-wp8/Plugins containing the plugin
.cs files), so this does work. On Windows and Mac, at any rate. I did leave it lowercase by
accident which I think is an issue on linux.. Let me fix that really quick.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org


Mime
View raw message