Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@cordova.apache.org
From: martincgg <git@git.apache.org>
To: dev@cordova.apache.org
Reply-To: dev@cordova.apache.org
References: <git-pr-117-cordova-android@git.apache.org>
In-Reply-To: <git-pr-117-cordova-android@git.apache.org>
Subject: [GitHub] cordova-android pull request: [CB-6837][Android] Fix: leaked
 windo...
Content-Type: text/plain
Message-Id: <20140919154242.19A339AD21F@tyr.zones.apache.org>
Date: Fri, 19 Sep 2014 15:42:42 +0000 (UTC)

Github user martincgg commented on a diff in the pull request:

    https://github.com/apache/cordova-android/pull/117#discussion_r17791920
  
    --- Diff: framework/src/org/apache/cordova/CordovaChromeClient.java ---
    @@ -123,7 +128,8 @@ public boolean onKey(DialogInterface dialog, int keyCode, KeyEvent event) {
                         return true;
                 }
             });
    -        dlg.show();
    +        AlertDialog alert = dlg.show();
    --- End diff --
    
    dlg.show(); can be added complete to the next line, avoiding variable creation.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---