cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: CB-7607 Add xxhdpi and xxxhdpi support t...
Date Mon, 22 Sep 2014 11:37:58 GMT
GitHub user sgrebnov opened a pull request:

    https://github.com/apache/cordova-lib/pull/89

    CB-7607 Add xxhdpi and xxxhdpi support to Android Cordova

    https://issues.apache.org/jira/browse/CB-7607
    
    Current Cordova template for Android does not have res sub-folders for xx and xxxhdpi
plus due to current splash/icons support implementation it is possible to replace already
existing drawables only(see var densities = this.deleteDefaultResource(...)). I don't think
we should always keep new hi res images as part of default template due to the their big size
so this commit improves splash/icons support implementation to make it possible to add drawables
for the densities which are not present in template by default.
    
    Example configuration for xxhdpi and xxxhdpi assets:
    ```
    <icon src="res/android/xxhdpi.png" density="xxhdpi" />
    <icon src="res/android/xxxhdpi.png" density="xxxhdpi" />
    
    <splash src="res/android/land-xxhdpi.png" density="land-xxhdpi" />
    <splash src="res/android/port-xxhdpi.png" density="port-xxhdpi" />
    
    <splash src="res/android/land-xxxhdpi.png" density="land-xxxhdpi" />
    <splash src="res/android/port-xxxhdpi.png" density="port-xxxhdpi" />
    ```


You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/MSOpenTech/cordova-lib CB-7607

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-lib/pull/89.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #89
    
----
commit f01e5b76ca67f728ce5680be252985574924e536
Author: sgrebnov <v-segreb@microsoft.com>
Date:   2014-09-22T11:19:37Z

    CB-7607 Add xxhdpi and xxxhdpi support to Android Cordova

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message