cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sebastienblanc <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: CB-7608 : add option use...
Date Mon, 22 Sep 2014 12:43:49 GMT
GitHub user sebastienblanc opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/66

    CB-7608 : add option useWidthViewPort (Android Platform) 

    When using inAppBrowser with Android, the viewport tag of the loaded page is ignored.
As a result, some pages using a specific viewport (for instance an Ionic view) are completly
zoomed out.
    With iOS it's possible to fix that by passing "enableViewportScale" but for Android the
only way to fix this is to set 'useWideViewPort' to 'false' . It's now harcoded to 'true'
https://github.com/apache/cordova-plugin-inappbrowser/blob/master/src/android/InAppBrowser.java#L620.
    We should be able to pass the value through the option (i.e : 'location=no, useWideViewPort=no')

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sebastienblanc/cordova-plugin-inappbrowser CB-7608

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/66.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #66
    
----
commit 5f8e3e4f153a9380605c34a5e0d717fe73d73af4
Author: Sebastien Blanc <scm.blanc@gmail.com>
Date:   2014-09-22T12:42:04Z

    add option useWidthViewPort

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message