cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-plugin-inappbrowser pull request: Windows implementation f...
Date Fri, 19 Sep 2014 06:43:02 GMT
GitHub user sgrebnov opened a pull request:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/64

    Windows implementation fixes and improvements

    1. Added {keepCallback: true} so that it can propagate several navigation events
    
    2. "calc(100% - 80px)" style instead of onresize callback and resizing manually
    
    3. I think it is better to use cordova.platformId to detect modern Windows version instead
of Api below which is subject for changes in the future - Scheduler.schedule could be renamed
in the future
    
        isWinJS2 = !!WinJS.Utilities.Scheduler && !!WinJS.Utilities.Scheduler.schedule

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/sgrebnov/cordova-plugin-inappbrowser windows-fixes

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-inappbrowser/pull/64.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #64
    
----
commit 32c0e41c431ac79ab18033c8b536c966b37e0db4
Author: sgrebnov <v-segreb@microsoft.com>
Date:   2014-09-19T06:33:53Z

    Windows implementation fixes and improvements

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message