cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From bpappin <...@git.apache.org>
Subject [GitHub] cordova-plugin-dialogs pull request: Added option to specify the i...
Date Wed, 03 Sep 2014 15:51:20 GMT
GitHub user bpappin opened a pull request:

    https://github.com/apache/cordova-plugin-dialogs/pull/30

    Added option to specify the input type of the prompt dialog

    I have only implemented it for Android and iOS, with Android being my primary language
and iOS being a light secondary skill, so treat accordingly.
    
    I did update the documentation in the JS file.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/bpappin/cordova-plugin-dialogs master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-dialogs/pull/30.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #30
    
----
commit e5963f5ac713c104f4ff2797593c1cc6359a38cb
Author: Brill Pappin <brill@pappin.ca>
Date:   2014-09-02T18:34:12Z

    added int param to control input type.

commit eced729cd34946170354f450bd0177513e7d197d
Author: Brill Pappin <brill@pappin.ca>
Date:   2014-09-02T19:34:47Z

    Properly allows setting of input type on android.

commit 4c375ee4cfed43a9350e17c031a00a77e590246a
Author: Brill Pappin <brill@pappin.ca>
Date:   2014-09-03T14:33:50Z

    iOS implementation

commit 07df93e77a3c3eec374dcd8274275e7a4b067439
Author: Brill Pappin <brill@pappin.ca>
Date:   2014-09-03T15:23:41Z

    the view style must be assigned before we try and access the textfield.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message