cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From agamemnus <...@git.apache.org>
Subject [GitHub] cordova-plugin-media pull request: Added fp.exists () false negati...
Date Thu, 11 Sep 2014 16:11:34 GMT
GitHub user agamemnus opened a pull request:

    https://github.com/apache/cordova-plugin-media/pull/27

    Added fp.exists () false negative shield.

    The Media API doesn't account for cases where fp.exists() may provide a false negative.
(For example, APK expansions...)
    
    Cosmetic: I also did a short-circuit on the first condition, converted to "} else {"s
instead of hanging brackets, and fixed the incorrect spacing in the last few lines. (caused
probably by the hanging brackets!)

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/agamemnus/cordova-plugin-media master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-media/pull/27.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #27
    
----
commit 6fd5193225c291a11b65e6a261b0974a30e30e8d
Author: agamemnus <agamemnus@gmail.com>
Date:   2014-09-11T16:10:10Z

    Added fp.exists () false negative shield.
    
    The Media API doesn't account for cases where fp.exists() may provide a false negative.
(For example, APK expansions...)
    
    Cosmetic: I also did a short-circuit on the first condition, converted to "} else {"s
instead of hanging brackets, and fixed the incorrect spacing in the last few lines. (caused
probably by the hanging brackets!)

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message