cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From digiclick74 <...@git.apache.org>
Subject [GitHub] cordova-plugin-geolocation pull request: Fix Android installation
Date Sun, 07 Sep 2014 11:04:26 GMT
GitHub user digiclick74 opened a pull request:

    https://github.com/apache/cordova-plugin-geolocation/pull/24

    Fix Android installation

    After the amazon installation the android cli installation miss to copy src and javascript
files in the project.
    
    I change the plugin.xml file and copy the amazon src directory content to and android
directory. The android directory is to respect the project structure. But now there ara a
duplication of code, in android and amazon directory.
    Another solution is to create only one directory for both platforms. What do you think?

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/digiclick74/cordova-plugin-geolocation master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-plugin-geolocation/pull/24.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #24
    
----
commit cbab6181aeeb4c7b8c686adf8a6227f9b70ccc25
Author: glauco.toso <glauco.toso@hp650.sede.crowdm.it>
Date:   2014-09-05T15:52:46Z

    Plugin.xml changes to correct android installation problem

commit 49759df31f853c578aa624e84972a151366df693
Author: digiclick74 <info@glaucotoso.it>
Date:   2014-09-07T10:19:53Z

    Revert "Plugin.xml changes to correct android installation problem"
    
    This reverts commit cbab6181aeeb4c7b8c686adf8a6227f9b70ccc25.

commit 22d92cbabb5a32076955174cbfc8b1141cdbacb6
Author: digiclick74 <info@glaucotoso.it>
Date:   2014-09-07T10:24:09Z

    Plugin.xml changes to correct android installation problem. Missing all src files and
javascript files in the android project

commit d5636fbc8abaaf152bceedfa3ca9d100ba646f4b
Author: digiclick74 <info@glaucotoso.it>
Date:   2014-09-07T10:56:02Z

    Plugin.xml changes to correct android installation problem. Missing all src files and
javascript files in the android project. Add also android src files for uniform with the project
structure

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message