cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From lyonplus <...@git.apache.org>
Subject [GitHub] cordova-ios pull request: Remove duplicate reference to the same l...
Date Wed, 24 Sep 2014 15:38:25 GMT
GitHub user lyonplus opened a pull request:

    https://github.com/apache/cordova-ios/pull/106

    Remove duplicate reference to the same libCordova.a.

    libCordova.a has already been referred to as a framework, no need to
    force_load it again.
    
    Normally it is OK to refer to libCordova.a twice, as they are the same
    file anyway. But when symbolic link is used in workspace and Jenkins is
    use to do the build, there will be a problem because Jenkins will
    dereference symbolic links (https://issues.jenkins-ci.org/browse/JENKINS-5597)
    and now we could have 2 copies of libCordova.a, and have countless
    duplicate symbols errors.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/lyonplus/cordova-ios master

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/cordova-ios/pull/106.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #106
    
----
commit bf6a1bc24d604eb7db113afd6bf9af8701ca076f
Author: Lianghui Chen <liachen@blackberry.com>
Date:   2014-09-22T19:24:58Z

    Remove duplicate reference to the same libCordova.a.
    
    libCordova.a has already been referred to as a framework, no need to
    force_load it again.
    
    Normally it is OK to refer to libCordova.a twice, as they are the same
    file anyway. But when symbolic link is used in workspace and Jenkins is
    use to do the build, there will be a problem because Jenkins will
    dereference symbolic links (https://issues.jenkins-ci.org/browse/JENKINS-5597)
    and now we could have 2 copies of libCordova.a, and have countless
    duplicate symbols errors.

----


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message