cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Joe Bowser <bows...@gmail.com>
Subject Re: Cordova CSS error on Android 4.4.x
Date Wed, 03 Sep 2014 22:32:02 GMT
This is the offending commit:
https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=67f474e

I knew that this was a bad idea, but I thought people would actually test
it themselves since they were convinced that I was wrong.  Sadly, we're now
dealing with their hubris.


On Wed, Sep 3, 2014 at 3:23 PM, Jesse <purplecabbage@gmail.com> wrote:

> Can you post a link to the offending commit?
>
> @purplecabbage
> risingj.com
>
>
> On Wed, Sep 3, 2014 at 3:21 PM, Joe Bowser <bowserj@gmail.com> wrote:
>
> > It turns out that the change proposed by a user was merged in without any
> > testing, or without any testing that would have caught this pretty major
> > bug.  Of course, we didn't catch it because MobileSpec is black and our
> > default background colour is black.  I'm going to land the commit in
> 3.6.0
> > and master, but we really need to actually test when we merge things in
> and
> > not just merge them in because the person doesn't like me, which I think
> > was the case here.  You can't set the colour of an App View without it
> > having negative consequences on stock Android, or non-Samsung devices.
> >
> > I can't believe people approved a release without doing a simple check
> like
> > this.  This is insane!
> >
> >
> > On Wed, Sep 3, 2014 at 2:58 PM, Joe Bowser <bowserj@gmail.com> wrote:
> >
> > > Hey
> > >
> > > I just tested on KitKat the 3.6.0 release and I noticed the page when
> you
> > > first create a Cordova application is Black.  It's the correct colour
> on
> > L,
> > > but that's not super helpful since L isn't even on any devices at the
> > > moment AFAIK.
> > >
> > > Has there been any changes that would cause the background colour to be
> > > black? I know I could check the commit log, but I'm hoping this is
> > faster.
> > >  I'm probably going to -1 the release because of this, since this seems
> > > like a pretty obvious problem.
> > >
> > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message