cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Jesse <purplecabb...@gmail.com>
Subject Re: Plugin PRs ( from Sergey )
Date Fri, 19 Sep 2014 20:48:03 GMT
Done

@purplecabbage
risingj.com

On Thu, Sep 18, 2014 at 11:46 PM, Sergey Grebnov (Akvelon) <
v-segreb@microsoft.com> wrote:

> Thank you Jesse!
>
> Media-capture PR has been rebased.
>
> https://github.com/apache/cordova-plugin-media-capture/pull/26#issuecomment-56118695
>
> InAppBrowser - I've closed my original PR but sent another one since it
> contains one critical fix to make it working correct (keepCallback), more
> details are here:
> https://github.com/apache/cordova-plugin-inappbrowser/pull/64
>
> Thx!
> Sergey
> -----Original Message-----
> From: Jesse [mailto:purplecabbage@gmail.com]
> Sent: Friday, September 19, 2014 3:58 AM
> To: dev@cordova.apache.org
> Subject: Plugin PRs ( from Sergey )
>
> All reviewed and merged Sergey.
>
> Merge issue in media-capture#26, may already be implemented ...
>
> https://github.com/apache/cordova-plugin-media-capture/pull/26#issuecomment-56118695
>
> And I chose #52 over #53 for inappbrowser You should be able to close
> https://github.com/apache/cordova-plugin-inappbrowser/pull/53
>
>
>
>
>
>
> >>> original message from Sergey
>
> Hi, I'm still waiting for the following PRs to be reviewed/merged. Most of
> them are critical to have plugins working on Windows 8.1 and Windows Phone
> 8.1, so if they are not merged by my morning, I'll merge the fixes by
> myself since they are very local and affect windows only.
>
> Bugfixing related to new Windows universal platform
> https://github.com/apache/cordova-plugin-contacts/pull/43
> https://github.com/apache/cordova-plugin-contacts/pull/44
>
> https://github.com/apache/cordova-plugin-media/pull/26
>
> https://github.com/apache/cordova-plugin-media-capture/pull/25
> https://github.com/apache/cordova-plugin-media-capture/pull/26
>
> Improvement
> https://github.com/apache/cordova-plugin-inappbrowser/pull/53
>
> Thx!
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message