cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Michal Mocny <mmo...@chromium.org>
Subject Re: Cordova CSS error on Android 4.4.x
Date Thu, 04 Sep 2014 16:08:51 GMT
I did that and did not see this.  Very weird.  Which device/os version are
you using?


On Thu, Sep 4, 2014 at 11:55 AM, Joe Bowser <bowserj@gmail.com> wrote:

> On Thu, Sep 4, 2014 at 7:09 AM, Michal Mocny <mmocny@chromium.org> wrote:
>
> > Not that you were asking, but I've repro-ed here.
> >
> > To do so, you seem to have to remove all app styling.  Then the default
> > background color is black not white (tests on Nexus4 running 4.4 as
> > suggested by Joe).
> >
>
>
> I didn't have to remove any app styling.
>
>
> >
> > You won't notice this with the default cordova project, nor mobile-spec,
> > since they set background color in its default styling.  That likely
> > explains why it wasn't caught during the release testing.
> >
> >
> The default colour is black.  All I did was run the create script to create
> an app.  This broke the default cordova project.
>
> Perhaps we should add a (few?) pages to mobile-spec that we should confirm
> > render correctly before a release?
> >
> > -Michal
> >
> >
> > On Wed, Sep 3, 2014 at 6:38 PM, Joe Bowser <bowserj@gmail.com> wrote:
> >
> > > At any rate, I'm going to re-tag the release on Android, since we can't
> > > release the current tag.
> > >
> > >
> > > On Wed, Sep 3, 2014 at 3:32 PM, Joe Bowser <bowserj@gmail.com> wrote:
> > >
> > > > This is the offending commit:
> > > >
> > https://git-wip-us.apache.org/repos/asf?p=cordova-android.git;h=67f474e
> > > >
> > > > I knew that this was a bad idea, but I thought people would actually
> > test
> > > > it themselves since they were convinced that I was wrong.  Sadly,
> we're
> > > now
> > > > dealing with their hubris.
> > > >
> > > >
> > > > On Wed, Sep 3, 2014 at 3:23 PM, Jesse <purplecabbage@gmail.com>
> wrote:
> > > >
> > > >> Can you post a link to the offending commit?
> > > >>
> > > >> @purplecabbage
> > > >> risingj.com
> > > >>
> > > >>
> > > >> On Wed, Sep 3, 2014 at 3:21 PM, Joe Bowser <bowserj@gmail.com>
> wrote:
> > > >>
> > > >> > It turns out that the change proposed by a user was merged in
> > without
> > > >> any
> > > >> > testing, or without any testing that would have caught this pretty
> > > major
> > > >> > bug.  Of course, we didn't catch it because MobileSpec is black
> and
> > > our
> > > >> > default background colour is black.  I'm going to land the commit
> in
> > > >> 3.6.0
> > > >> > and master, but we really need to actually test when we merge
> things
> > > in
> > > >> and
> > > >> > not just merge them in because the person doesn't like me, which
I
> > > think
> > > >> > was the case here.  You can't set the colour of an App View
> without
> > it
> > > >> > having negative consequences on stock Android, or non-Samsung
> > devices.
> > > >> >
> > > >> > I can't believe people approved a release without doing a simple
> > check
> > > >> like
> > > >> > this.  This is insane!
> > > >> >
> > > >> >
> > > >> > On Wed, Sep 3, 2014 at 2:58 PM, Joe Bowser <bowserj@gmail.com>
> > wrote:
> > > >> >
> > > >> > > Hey
> > > >> > >
> > > >> > > I just tested on KitKat the 3.6.0 release and I noticed
the page
> > > when
> > > >> you
> > > >> > > first create a Cordova application is Black.  It's the correct
> > > colour
> > > >> on
> > > >> > L,
> > > >> > > but that's not super helpful since L isn't even on any devices
> at
> > > the
> > > >> > > moment AFAIK.
> > > >> > >
> > > >> > > Has there been any changes that would cause the background
> colour
> > to
> > > >> be
> > > >> > > black? I know I could check the commit log, but I'm hoping
this
> is
> > > >> > faster.
> > > >> > >  I'm probably going to -1 the release because of this, since
> this
> > > >> seems
> > > >> > > like a pretty obvious problem.
> > > >> > >
> > > >> > >
> > > >> > >
> > > >> >
> > > >>
> > > >
> > > >
> > >
> >
>

Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message