cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Lyon Chen <lyonp...@gmail.com>
Subject Anyone to review patches to remove duplicate reference to libCordova in cordova-ios?
Date Tue, 30 Sep 2014 17:52:26 GMT
Hi

I have a pull request (https://github.com/apache/cordova-ios/pull/106#issuecomment-56723894)
for issue (https://issues.apache.org/jira/browse/CB-7627). Basically it is about 2 references
to the same libCordova.a file, one as add in commit fe397173 as force_load, the other one
is add in commit ec2d51dd as a framework. And this causes problem when Jenkins is used to
build and symbolic links is used in workspace, because Jenkins has a bug/feature that always
dereference symbolic links to actual files.

The force_load situation is also talked about in http://stackoverflow.com/questions/4787279/xcode-get-force-load-to-work-with-relative-paths,
which mentioned now “-ObjC” is good enough for Xcode 4 and up.

So can someone take the time to have a look at my pull request (https://github.com/apache/cordova-ios/pull/106#issuecomment-56723894)
to see whether it makes sense and can be merged?

Thanks
Lyon
Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message