cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: [CB-6469] url and local save/restore sup...
Date Tue, 30 Sep 2014 08:53:28 GMT
Github user sgrebnov commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/86#discussion_r18205524
  
    --- Diff: cordova-lib/src/cordova/restore.js ---
    @@ -70,29 +70,23 @@ function installPluginsFromConfigXML(cfg) {
         }
     
         return features.reduce(function(soFar, featureId) {
    -
             var pluginPath =  path.join(plugins_dir, featureId);
             if (fs.existsSync(pluginPath)) {
                 // Plugin already exists
                 return soFar;
             }
    -
             return soFar.then(function() {
                 events.emit('log', 'Discovered ' + featureId + ' in config.xml. Installing
to the project');
    -
                 var feature = cfg.getFeature(featureId);
     
                 // Install from given URL if defined or using a plugin id
    -            var installFrom = feature.url;
    -            if (!installFrom) {
    -                installFrom = feature.id;
    -                if (!!feature.version) {
    -                    installFrom += ('@' + feature.version);
    -                }
    +            var installFrom = feature.url || feature.installPath || feature.id;
    +            if( feature.version && !feature.url && !feature.installPath
){
    +                installFrom += ('@' + feature.version);
                 }
    -
    +            console.log('Install from ' + installFrom);
    --- End diff --
    
    It is better to use 
    events.emit('log', ...


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message