cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From shazron <...@git.apache.org>
Subject [GitHub] cordova-plugin-contacts pull request: fix a nasty memory leak on i...
Date Mon, 15 Sep 2014 18:05:32 GMT
Github user shazron commented on the pull request:

    https://github.com/apache/cordova-plugin-contacts/pull/35#issuecomment-55631636
  
    The CFRetain there is correct since we do want to keep a reference to the record. The
memory leak still occurs however, since we don't have a dealloc in the class to handle the
CFRelease of the record.
    
    This pull request should be closed, and the "add a search limit" feature should be sent
as a separate PR


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message