cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From sgrebnov <...@git.apache.org>
Subject [GitHub] cordova-windows pull request: CB-7494 Fixes wrong replacements in ...
Date Tue, 09 Sep 2014 08:19:17 GMT
Github user sgrebnov commented on a diff in the pull request:

    https://github.com/apache/cordova-windows/pull/44#discussion_r17287461
  
    --- Diff: windows/bin/lib/create.js ---
    @@ -66,8 +68,8 @@ module.exports.run = function (argv) {
         ["package.windows.appxmanifest", "package.windows80.appxmanifest", "package.phone.appxmanifest"].forEach(function
(file) {
             var fileToReplace = path.join(projectPath, file);
             shell.sed('-i', /\$guid1\$/g, guid, fileToReplace);
    -        shell.sed('-i', /\$safeprojectname\$/g, safeAppName, fileToReplace);
    -        shell.sed('-i', /\$projectname\$/g, packageName, fileToReplace);
    +        shell.sed('-i', /\$safeprojectname\$/g, packageName, fileToReplace);
    --- End diff --
    
    Vladimir, could you please also file separate issue to correct placeholders names; looks
like 
    $(safe)projectname is actually a package name. I would refine those names moving forward


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message