cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From smistry-toushay <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: Add support for plugin symbolic links
Date Mon, 08 Sep 2014 12:12:58 GMT
Github user smistry-toushay commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/78#discussion_r17233889
  
    --- Diff: cordova-lib/src/plugman/uninstall.js ---
    @@ -104,7 +104,12 @@ module.exports.uninstallPlugin = function(id, plugins_dir, options)
{
                 return Q();
             }
     
    -        shell.rm('-rf', plugin_dir);
    +        if (fs.lstatSync(plugin_dir).isSymbolicLink()) {
    --- End diff --
    
    @mbektchiev but it also recursively deletes the files inside the folder the symbolic link
points to (observed this on OS X).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message