cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From mbektchiev <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: Add support for plugin symbolic links
Date Mon, 08 Sep 2014 11:40:13 GMT
Github user mbektchiev commented on a diff in the pull request:

    https://github.com/apache/cordova-lib/pull/78#discussion_r17232882
  
    --- Diff: cordova-lib/src/plugman/uninstall.js ---
    @@ -104,7 +104,12 @@ module.exports.uninstallPlugin = function(id, plugins_dir, options)
{
                 return Q();
             }
     
    -        shell.rm('-rf', plugin_dir);
    +        if (fs.lstatSync(plugin_dir).isSymbolicLink()) {
    --- End diff --
    
    This check is not necessary. `shell.rm` already removes symbolic links correctly.
    See: https://github.com/arturadib/shelljs/blob/master/src/rm.js#L117


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message