cordova-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From csantanapr <...@git.apache.org>
Subject [GitHub] cordova-lib pull request: Adding the sugar platform to cordova
Date Wed, 03 Sep 2014 16:28:38 GMT
Github user csantanapr commented on the pull request:

    https://github.com/apache/cordova-lib/pull/83#issuecomment-54324098
  
    Please associate this pull request with a JIRA item.
    Process can be found here: http://wiki.apache.org/cordova/ContributorWorkflow
    I think before this code can be merge only when the sugar platform is added to the  Apache
Git Repo and part of Cordova like the other platforms. Currently Cordova CLI only supports
platforms that are part of the Apache Cordova Project.
    The current expectation for end users using the Cordova CLI is that all source code used
by Cordova is "blessed" by Apache Cordova Project. 
    So that means that https://api.github.com/repos/puneetgkaur/cordova-sugar/tarball/sugar?
in needs to be change to something like this: https://git-wip-us.apache.org/repos/asf?p=cordova-sugar.git
in platforms.js
    
    If you don't want or can't contribute the cordova-sugar platform to Apache Cordova Project,
the cli is working on supporting platforms from npm. This could open the door for anyone to
have a platform implementation use by cordova cli, but this is something to be discuss in
the cordova mailing list on how is going to be handle to be very clear to end users what code
is from Apache and what is not.
    
    Could you add some unit test cases under cordova-lib/spec-cordova and cordova-lib/spec-plugman
?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---

Mime
View raw message