Return-Path: X-Original-To: apmail-cordova-dev-archive@www.apache.org Delivered-To: apmail-cordova-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 29D7C1122C for ; Wed, 27 Aug 2014 22:36:26 +0000 (UTC) Received: (qmail 43132 invoked by uid 500); 27 Aug 2014 22:36:25 -0000 Delivered-To: apmail-cordova-dev-archive@cordova.apache.org Received: (qmail 43090 invoked by uid 500); 27 Aug 2014 22:36:25 -0000 Mailing-List: contact dev-help@cordova.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@cordova.apache.org Delivered-To: mailing list dev@cordova.apache.org Received: (qmail 43068 invoked by uid 99); 27 Aug 2014 22:36:25 -0000 Received: from tyr.zones.apache.org (HELO tyr.zones.apache.org) (140.211.11.114) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 27 Aug 2014 22:36:25 +0000 Received: by tyr.zones.apache.org (Postfix, from userid 65534) id 46A42A01355; Wed, 27 Aug 2014 22:36:25 +0000 (UTC) From: martincgg To: dev@cordova.apache.org Reply-To: dev@cordova.apache.org Message-ID: Subject: [GitHub] cordova-plugin-file pull request: [CB-7418][DirectoryEntry] Added ... Content-Type: text/plain Date: Wed, 27 Aug 2014 22:36:25 +0000 (UTC) GitHub user martincgg opened a pull request: https://github.com/apache/cordova-plugin-file/pull/73 [CB-7418][DirectoryEntry] Added fullPath variable as part of condition As well as nativeUrl property, the fullPath variable should be part of the condition to avoid that a null value becoming a path, by adding a slash at the end of the undefined string, resulting in 'undefined/'. So in order to add a slash to it, fullPath should contain a value. You can merge this pull request into a Git repository by running: $ git pull https://github.com/martincgg/cordova-plugin-file CB-7418 Alternatively you can review and apply these changes as the patch at: https://github.com/apache/cordova-plugin-file/pull/73.patch To close this pull request, make a commit to your master/trunk branch with (at least) the following in the commit message: This closes #73 ---- commit ab42f3e7c6c2282ac303e32260e8d68fdd2e18e3 Author: Martin Gonzalez Date: 2014-08-27T22:34:05Z [CB-7418][DirectoryEntry] Added fullPath variable as part of condition As well as NativeURL property, the fullPath variable should be part of the condition to avoid that a null value becomes a path, by adding a slash at the end of the undefined string. So in order to add a slash to it, fullPath should contain a value. ---- --- If your project is set up for it, you can reply to this email and have your reply appear on GitHub as well. If your project does not have this feature enabled and wishes so, or if the feature is enabled but not working, please contact infrastructure at infrastructure@apache.org or file a JIRA ticket with INFRA. ---